Skip to content

Patch: fix for non-extension files - #373

Merged
dapineyro merged 4 commits into
mainfrom
patch/recognise_extensionless_filepaths
Sep 18, 2026
Merged

dapineyro merged 4 commits into
mainfrom
patch/recognise_extensionless_filepaths

Conversation

@dapineyro

@dapineyro dapineyro commented Sep 17, 2026 •

Copy link
Copy Markdown
Collaborator

Overview

Bug to fix: Files without file extension are not recognised as files when they are submitted as parameters in Bash jobs and array jobs.

JIRA

Changes

  • Resolve extensionless Data/ paths as file references.
  • Correct project detection for nested Data/ paths.
  • Add regression tests, update docs/changelog, and bump to 2.96.1.

Acceptance Criteria

  • Extensionless files resolve across current and explicit projects; missing files fail before submission.
  • Text values, existing file parameters, and glob patterns retain their behavior.
  • 608 tests passed locally; five logging tests required a temporary log directory.

PROD (ADAPT)

Before the fix 🔴

We try to add a parameter file: --parameter --file=ci-testing/Data/bash_array/input

(testpip) dpineyro@Lifebit-QXDXLP41DQ cloudos-cli % cloudos bash array-job \
          --instance-type m4.xlarge \
          --memory 2 \
          --parameter -test=value \
          --parameter --gaq=test \
          --array-parameter --array_var=title \
          --job-name "before_fix" \
          --command "echo 'test' > new_file.txt" \
          --project-name "cloudos-cli-tests" \
          --workflow-name "plink2-lifebiai-dockerhub" \
          --array-file Data/bash_array/sampleArray.csv \
          --separator "," \
          --parameter --file=ci-testing/Data/bash_array/input \
          --last
CloudOS CLI python package: a package for interacting with Lifebit Platform.

Version: 2.95.1

Lifebit Platform bash-specific job functionality.


Checking columns in the array file vs parameters added...

Found column 'title' in the array file.
	Job successfully launched to Lifebit Platform, please check the following link: https://cloudos.lifebit.ai/app/advanced-analytics/analyses/6aad1b0399aa89690e55e3be
	Your assigned job id is: 6aad1b0399aa89690e55e3be

	Your current job status is: initializing
	To further check your job status you can either go to https://cloudos.lifebit.ai/app/advanced-analytics/analyses/6aad1b0399aa89690e55e3be or use the following command:
	cloudos job status \
		--profile my_profile \
		--job-id 6aad1b0399aa89690e55e3be

But it is not recognised as a file and instead recognised as a string:
https://cloudos.lifebit.ai/app/advanced-analytics/analyses/6aad1b0399aa89690e55e3be
Screenshot 2026-09-18 at 13 18 07
No FileTransfers
Screenshot 2026-09-18 at 13 18 45

After the fix 🟢

(cloudos-cli) dpineyro@Lifebit-QXDXLP41DQ cloudos-cli % cloudos bash array-job \                      
          --instance-type m4.xlarge \
          --memory 2 \
          --parameter -test=value \
          --parameter --gaq=test \
          --array-parameter --array_var=title \
          --job-name "after_fix" \
          --command "echo 'test' > new_file.txt" \
          --project-name "cloudos-cli-tests" \
          --workflow-name "plink2-lifebiai-dockerhub" \
          --array-file Data/bash_array/sampleArray.csv \
          --separator "," \
          --parameter --file=ci-testing/Data/bash_array/input \
          --last
CloudOS CLI python package: a package for interacting with Lifebit Platform.

Version: 2.96.1

Lifebit Platform bash-specific job functionality.


Checking columns in the array file vs parameters added...

Found column 'title' in the array file.
	Job successfully launched to Lifebit Platform, please check the following link: https://cloudos.lifebit.ai/app/advanced-analytics/analyses/6aad1c1d985c161657184102
	Your assigned job id is: 6aad1c1d985c161657184102

	Your current job status is: scheduled
	To further check your job status you can either go to https://cloudos.lifebit.ai/app/advanced-analytics/analyses/6aad1c1d985c161657184102 or use the following command:
	cloudos job status \
		--profile my_profile \
		--job-id 6aad1c1d985c161657184102

The parameter is now recognised as a file and staged into the process:
https://cloudos.lifebit.ai/app/advanced-analytics/analyses/6aad1c1d985c161657184102
Screenshot 2026-09-18 at 13 20 19
Screenshot 2026-09-18 at 13 20 40

AZURE

Not relevant

Interactive Analysis

Not relevant

Copilot AI lite review requested due to automatic review settings September 17, 2026 16:49

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No unresolved blocking issues were identified.

Pull request overview

Fixes resolution of extensionless File Explorer paths in Bash and Bash array jobs.

Changes:

  • Corrects nested Data/ path and project extraction.
  • Adds regression tests for Bash and array jobs.
  • Updates documentation, changelog, and version.
File summaries
File Reviewed change
tests/test_bash/test_send_bash_array_job_multi_project.py Verifies array-job file references.
tests/test_bash/test_docker_workflow_param_processing.py Adds regression coverage.
README.md Documents extensionless file parameters.
cloudos_cli/utils/array_job.py Corrects project extraction for nested paths.
cloudos_cli/jobs/job.py Resolves extensionless Data/ files.
cloudos_cli/_version.py Bumps the package version.
CHANGELOG.md Records the fix.
Review details
  • Files reviewed: 7/7 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@dapineyro
dapineyro marked this pull request as draft September 17, 2026 17:00
@dapineyro
dapineyro marked this pull request as ready for review September 17, 2026 17:00
@dapineyro
dapineyro marked this pull request as draft September 18, 2026 10:54
@dapineyro
dapineyro marked this pull request as ready for review September 18, 2026 10:54

@danielboloc danielboloc left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dapineyro
dapineyro merged commit a981dd8 into main Sep 18, 2026
102 checks passed
@dapineyro
dapineyro deleted the patch/recognise_extensionless_filepaths branch September 18, 2026 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants