Repository navigation
Rebuild bin/libphf.dylib with the v1.1 encode options API - #2
Merged
Merged
Conversation
The bundled macOS library still came from libphf/phf 8086543, so encoder.py fell back to the legacy 5-argument call and missed the FAST effort. Rebuilt from libphf/phf 1cb1f80 (universal arm64 + x86_64, macOS 11+, no OpenMP, only libSystem); bin/README.md updated, and it now notes that phf.dll is v1.1 too. Webcam 1080p on Apple M3 Pro: 30.0 fps with this library (27.8 fps with the legacy one). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
libphf
added a commit
that referenced
this pull request
Oct 28, 2026
Rebuild bin/libphf.dylib with the v1.1 encode options API
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mainalready has the v1.1phf.dlland the ABI-detectingencoder.py, but the bundled macOSbin/libphf.dylibstill came from libphf/phf8086543. On macOS the encoder therefore fell back to the legacy 5-argument call (_has_options == False) and missed the FAST effort from libphf/phf#2.bin/libphf.dylibrebuilt from libphf/phf1cb1f80(universal arm64 + x86_64, macOS 11+, no OpenMP, onlylibSystem).bin/README.md: records the new source commit and thatphf.dllis v1.1.Supersedes #1 (closed: it predated the v1.1
phf.dllandencoder.pyonmain).Test plan
PHFEncoder()._has_optionsisTruewith this library (wasFalse).web/phf.wasm(rc 0, no transparent pixels).🤖 Generated with Claude Code