normalize traffic monitor log paths in a final always() step - #231
Merged
Conversation
run.sh renames the traffic monitor logs that actions/upload-artifact refuses, but it does so right after vmtest returns, so nothing renames them when the vmtest step does not get that far. Callers upload the directory with if: always(), so the upload still runs and fails on the leftover names: Error: The path for one of the files in artifact is not valid: /packets-125-15-net_timestamping__INET4:_bpf_timestamping-net_timestamping_ns.log. Contains the following character: Colon : Move the call out of run.sh into a last step of the action, guarded by if: always(), so it runs whatever happened to the step before it. The script already returns early when the directory does not exist, which is the case for every test that does not enable the traffic monitor. Signed-off-by: Vineet Gupta <vineet.gupta@linux.dev>
This was referenced Aug 11, 2026
theihor
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
run.sh renames the traffic monitor logs that actions/upload-artifact refuses, but it does so right after vmtest returns, so nothing renames them when the vmtest step does not get that far. Callers upload the directory with if: always(), so the upload still runs and fails on the leftover names:
Error: The path for one of the files in artifact is not valid:
/packets-125-15-net_timestamping__INET4:_bpf_timestamping-net_timestamping_ns.log.
Contains the following character: Colon :
Move the call out of run.sh into a last step of the action, guarded by if: always(), so it runs whatever happened to the step before it. The script already returns early when the directory does not exist, which is the case for every test that does not enable the traffic monitor.
This was initially proposed as vmtest but that does copy/paste.