Repository navigation
Fix bounded OCR dispatch retries for dropped connections and incomplete ACKs - #3
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A dropped connection or truncated ACK could fail OCR dispatch after one HTTP request, even when the backend had received the submission. Retry connection resets, premature EOF, incomplete bodies and malformed JSON/UTF-8 with bounded exponential backoff and jitter. Detect short Content-Length bodies explicitly because a bounded HTTP read can return them without an exception.
Keep the existing maximum of four attempts and 90-second total deadline. Every attempt reuses the same snapshot request ID, payload and workflow rerun key. A v2 durable acceptance ACK ends the job immediately, without waiting for review completion or commit-status publication. Permanent HTTP errors, oversized responses and invalid response lengths still fail promptly.
Emit one structured log per request with attempt, request ID, elapsed milliseconds, HTTP status, error type and retry delay. Logs exclude credentials and response bodies.
Validation:
Implemented and reviewed with Codex (GPT-6.1).