Repository navigation
Order templates and system types by Modelica package order - #661
Merged
Merged
Conversation
This was referenced Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This addresses #660.
Testing
Regression: the regenerated
templates.jsonis unchanged, and the existing server, client and golden tests pass.template-order.test.ts(new)package.orderand declaration order. TheOrderPackagefixture covers an order that isn't alphabetical, a nested system type, and a package stored in a single file.package.orderthat is missing, leaves out a template, or lists one twice.package.orderbut not on the path to any template raises none.unicode.test.ts: a template declared inside its package's file is found, with the right system type.quoted-identifiers.test.ts: the client fixture it writes no longer depends on test order.