feat(shell): cssGraphics ring spinner on every cold start - #1058
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only pages with an arrival photo had a cold-start loader, a faint 2px bar at the top. Now every body page shows cssGraphics' ring spinner (30px, 2px border, 0.8s spin) centred until the first body presents. The router already removes it when the body presents or fails; a failed app import now removes it too, and it stays hidden without JavaScript.
Limits: no screenshot yet; the dev server's /mars/ HTML contains the spinner.
Clean: no test suites run; no test pins the loader.