Repository navigation
docs: say which pages scroll from a layout with their view models - #3225
Merged
Merged
Conversation
The 1.136.156 and 1.136.157 entries named the pages that scroll at the default window from a layout with no data, which shows every status line a page can show and none of its data. Laid out with each page's own view model and nothing running, two scroll there: System Fixes by 169 px and Ping by 92 px under its five default targets. Quick Cleanup, Scheduled Maintenance and Windows Update fit, and so do Bandwidth Monitor, Resource History and Settings Watchdog. The entries now say so, mark the no-data figures as such, and say what they first said.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The 1.136.156 and 1.136.157 entries say which pages scroll at the default window. I measured those from a layout with no data, the way
PageHeightTestslays pages out. With noDataContextevery bound status line and both halves of a chart-or-empty-state pair show at once, and every list is empty, so the heights are not the page a user sees.Laid out instead with each page's own view model, nothing running and the app not elevated, at 1,044 x 781, here is how far each page scrolls:
Elevated, the figures are a little lower (System Fixes 181 and 169, Settings Watchdog 119 and 83), and nothing else changes.
The entries were wrong both ways. 1.136.156 named Scheduled Maintenance and Windows Update among the pages that scroll, and 1.136.157 said Ping and Settings Watchdog fitted and Quick Cleanup still scrolled, by 69 px.
The release notes of both versions and the two issue comments that repeat the claims get the same correction once this is in.
No code changes, so no release.