feat: Add FDv2 source traits and result types - #187
Open
beekld wants to merge 3 commits into
Open
Conversation
beekld
force-pushed
the
bklimt/SDK-2700/fdv2-source-traits
branch
from
August 10, 2026 18:41
cd0efbd to
77401d5
Compare
beekld
force-pushed
the
bklimt/SDK-2700/fdv2-source-traits
branch
from
August 10, 2026 18:46
77401d5 to
6b2995e
Compare
beekld
marked this pull request as ready for review
August 10, 2026 20:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Defines the interfaces the FDv2 data sources implement, ahead of the concrete polling and streaming sources. This adds:
InitializerandSynchronizertraits, whose methods return a boxed future so the traits stay object-safe.FDv2SourceResultenum returned by those methods, plus its accompanying event and error types.Note
Overview
Introduces the FDv2 data-source contract that upcoming polling/streaming implementations will share.
Adds
sourceunderfdv2withInitializer(run→ boxed future) andSynchronizer(next(selector)→ boxed future), both object-safe viaBoxFuture. Each call yields anFDv2SourceEventwrappingFDv2SourceResult(ChangeSet, recoverableInterrupted,TerminalError,Shutdown,Goodbye) plus optionalFDv1FallbackDirective(TTL). SharedErrorKind/ErrorInfotypes classify failures for status reporting later.Reviewed by Cursor Bugbot for commit 6b2995e. Bugbot is set up for automated code reviews on this repo. Configure here.