Skip to content

chore: Describe current aclose behavior in async redis store - #479

Merged
jsonbailey merged 1 commit into
mainfrom
jb/sdk-60/redis-comment-cleanup
Aug 4, 2026
Merged

chore: Describe current aclose behavior in async redis store#479
jsonbailey merged 1 commit into
mainfrom
jb/sdk-60/redis-comment-cleanup

Conversation

@jsonbailey

@jsonbailey jsonbailey commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Rewords a comment in the async Redis big segment store to describe current behavior instead of narrating version history.

Before: # aclose() replaced the async close() in redis-py 5.0.1; the [redis] extra allows >= 4.2
After: # Prefer aclose() (redis-py 5.0.1+); older supported versions (>= 4.2) only have close().

Comment-only; no behavior change. Part of the async comment-style cleanup.


Note

Low Risk
Documentation-only comment change with no executable code or dependency changes.

Overview
Comment-only update in _AsyncRedisBigSegmentStore.stop(): the note above the aclose() / close() branch is reworded to describe current behavior (prefer aclose() on redis-py 5.0.1+, fall back to close() on older supported redis-py ≥ 4.2) instead of narrating that aclose() replaced close() in 5.0.1.

No logic, dependencies, or runtime behavior changes.

Reviewed by Cursor Bugbot for commit 2abb495. Bugbot is set up for automated code reviews on this repo. Configure here.

@jsonbailey
jsonbailey requested a review from a team as a code owner August 4, 2026 17:00
@jsonbailey jsonbailey closed this Aug 4, 2026
@jsonbailey
jsonbailey deleted the jb/sdk-60/redis-comment-cleanup branch August 4, 2026 17:03
@jsonbailey
jsonbailey restored the jb/sdk-60/redis-comment-cleanup branch August 4, 2026 17:33
@jsonbailey jsonbailey reopened this Aug 4, 2026
@jsonbailey jsonbailey changed the title docs: Describe current aclose behavior in async redis store chore: Describe current aclose behavior in async redis store Aug 4, 2026
@jsonbailey
jsonbailey merged commit b5aadec into main Aug 4, 2026
28 of 29 checks passed
@jsonbailey
jsonbailey deleted the jb/sdk-60/redis-comment-cleanup branch August 4, 2026 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants