chore(setup): add setup flag verifier - #752
Merged
Merged
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 00ada35. Configure here.
ffantl-ld
force-pushed
the
ffantl/setup-ld/4-verifier
branch
from
July 31, 2026 17:48
00ada35 to
eff8764
Compare
ffantl-ld
force-pushed
the
ffantl/setup-ld/4-verifier
branch
from
July 31, 2026 18:25
eff8764 to
8a8d586
Compare
ffantl-ld
force-pushed
the
ffantl/setup-ld/4-verifier
branch
from
August 3, 2026 18:52
8a8d586 to
7fa9e73
Compare
ffantl-ld
force-pushed
the
ffantl/setup-ld/4-verifier
branch
from
August 3, 2026 19:48
7fa9e73 to
0532976
Compare
erangeles
approved these changes
Aug 5, 2026
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
sdk-active answers for any SDK that initialized in the environment in the past seven days, so verification passed on unrelated traffic and a project already using LaunchDarkly reported success without the new SDK ever connecting. Filter on sdk_name, mapping the setup SDK id to the name the SDK reports itself as. An unknown id sends no filter rather than one that can never match, and VerifyResult records which name was used so an unnarrowed check cannot present itself as narrowed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
ffantl-ld
force-pushed
the
ffantl/setup-ld/4-verifier
branch
from
August 5, 2026 18:06
0532976 to
a3d17ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the solution you've provided
Fourth layer of the guided
setupcommand: the verifier. Polls the LaunchDarkly API to confirm the newly configured SDK has evaluated a flag, sosetupcan report success (Verifier,DefaultVerifier). Uses the existingresources.Client.Related issues
Part of the
setup-ldfeature. Stacked PR — base isffantl/setup-ld/3-initializer.Requirements
Note
Low Risk
New setup-only polling helper with mocked HTTP tests; no changes to auth, CLI command wiring, or production request paths beyond calling the existing client.
Overview
Adds the setup verifier layer: after init injects runnable SDK code,
Verifierpolls LaunchDarkly’ssdk-activeAPI until the configured SDK shows as active or a timeout (default 120s / 5s interval), returning attempts and elapsed time inVerifyResult.Requests are scoped with an
sdk_namequery mapped from setup SDK ids (e.g.node-server→node-server-sdk) so existing environment activity does not count as success; unknown SDK ids skip the filter.DefaultVerifierwires this through the existingresources.Client.Tests cover success, timeout, filter behavior, and that every in-place-inject SDK has a reported name.
Reviewed by Cursor Bugbot for commit a3d17ca. Bugbot is set up for automated code reviews on this repo. Configure here.