Skip to content

feat(launchdarkly): support remove_members for synced segments - #137

Closed
saurabh-zeo wants to merge 1 commit into
launchdarkly:mainfrom
saurabh-zeo:main
Closed

saurabh-zeo wants to merge 1 commit into
launchdarkly:mainfrom
saurabh-zeo:main

Conversation

@saurabh-zeo

@saurabh-zeo saurabh-zeo commented Sep 28, 2026 •

Copy link
Copy Markdown

Requirements

Intended availability
This is a modification to the existing Zeotap integration and does not introduce a new integration.

If you're adding a new integration, let us know if you are a community member or a partner.

If you are a partner, your integration will be available to all customers.

If you're part of the community and submitting an integration for your own purposes or internal teams, specify your company name so that we can verify your identity and enable the integration for your account.

Related issues

Provide links to any issues in this repository or elsewhere relating to this pull request.

Describe the solution you've provided

If you're adding a new integration, provide some context into how LaunchDarkly and the third-party service should interact.

If you're modifying an existing integration, provide a clear and concise description of what you expect to happen.

Describe alternatives you've considered

If you're modifying an existing integration, provide a clear and concise description of any alternative solutions or features you've considered.

Provide a request preview

Include the output from running npm run preview <INTEGRATION_NAME>.

Additional context

Add any other context about the pull request here.


Note

Overview
The Zeotap synced-segment integration now treats remove_members as a valid /action value alongside members and add_members, so incoming Zeotap payloads that remove users from an audience are parsed and applied to LaunchDarkly Big Segments instead of being ignored.

The only code change is widening the requestParser.arrayInclusion.matcher regex in integrations/zeotap/manifest.json.

Reviewed by Cursor Bugbot for commit 36de948. Bugbot is set up for automated code reviews on this repo. Configure here.

@saurabh-zeo
saurabh-zeo requested a review from a team as a code owner September 28, 2026 11:10

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 36de948. Configure here.

"arrayInclusion": {
"path": "/action",
"matcher": "^(members|add_members)$"
"matcher": "^(members|add_members|remove_members)$"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove action treated as inclusion

High Severity

Adding remove_members to the arrayInclusion matcher causes those requests to add members instead of removing them. A match means include, so remove_members must not match; the previous ^(members|add_members)$ pattern already treated it as exclusion.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 36de948. Configure here.

@durw4rd

durw4rd commented Sep 28, 2026

Copy link
Copy Markdown
Contributor

I've reached out to the Zeotap team via email about this & suggested closing this PR. As far as I can tell, the desired functionality is already supported today, and this PR would actually break it.

@saurabh-zeo saurabh-zeo closed this Oct 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants