Skip to content

Fix overwrite of result of lTFromRhoSie - #669

Closed
AlexHls wants to merge 2 commits into
mainfrom
alexhls/fix-helmeos-ltfromrhosie
Closed

AlexHls wants to merge 2 commits into
mainfrom
alexhls/fix-helmeos-ltfromrhosie

Conversation

@AlexHls

@AlexHls AlexHls commented Nov 19, 2026

Copy link
Copy Markdown
Collaborator

PR Summary

At the end of the Helmholtz EOS table inversion function (lTFromRhoSie), the result is overwritten by the initial guess stored in the lambda indexer, making most EOS calls return values based on the initial guess, rather than the actual temperature.

PR Checklist

  • Adds a test for any bugs fixed. Adds tests for new features.
  • Format your changes by using the make format command after configuring with cmake.
  • Document any new features, update documentation for changes made.
  • Make sure the copyright notice on any files you modified is up to date.
  • After creating a pull request, note it in the CHANGELOG.md file.
  • LANL employees: make sure tests pass both on the github CI and on the Darwin CI
  • If ML was used, make sure to add a disclaimer at the top of a file indicating ML was used to assist in generating the file.
  • If Agentic AI was used, have the AI generate a "proposed changes" markdown file and store it in the plan_histories folder, with a filename the same as the MR number.

If preparing for a new release, in addition please check the following:

  • Update the version in cmake.
  • Move the changes in the CHANGELOG.md file under a new header for the new release, and reset the categories.
  • Maintainers: ensure spackages are up to date:
    • LANL-internal team, update XCAP spackages
    • Current maintainer of upstream spackages, submit MR to spack

@AlexHls AlexHls closed this Nov 19, 2026
@AlexHls
AlexHls deleted the alexhls/fix-helmeos-ltfromrhosie branch November 19, 2026 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant