Skip to content

Add analytic InternalEnergyFromDensityPressure methods to davis, mgusup, and powermg. - #668

Merged
buechlerm merged 16 commits into
mainfrom
buechler/Davis_EofRP
Nov 17, 2026
Merged

buechlerm merged 16 commits into
mainfrom
buechler/Davis_EofRP

Conversation

@buechlerm

@buechlerm buechlerm commented Nov 16, 2026 •

Copy link
Copy Markdown
Collaborator

PR Summary

Most (maybe all) of the analytic eos can have analytically determined internal energy given density and pressure. Here, I've added those for Davis reactants/products, the mg usup, and the power mg modes. I've also added some tests for them.

PR Checklist

  • Adds a test for any bugs fixed. Adds tests for new features.
  • Format your changes by using the make format command after configuring with cmake.
  • Document any new features, update documentation for changes made.
  • Make sure the copyright notice on any files you modified is up to date.
  • After creating a pull request, note it in the CHANGELOG.md file.
  • LANL employees: make sure tests pass both on the github CI and on the Darwin CI
  • If ML was used, make sure to add a disclaimer at the top of a file indicating ML was used to assist in generating the file.
  • If Agentic AI was used, have the AI generate a "proposed changes" markdown file and store it in the plan_histories folder, with a filename the same as the MR number.

If preparing for a new release, in addition please check the following:

  • Update the version in cmake.
  • Move the changes in the CHANGELOG.md file under a new header for the new release, and reset the categories.
  • Maintainers: ensure spackages are up to date:
    • LANL-internal team, update XCAP spackages
    • Current maintainer of upstream spackages, submit MR to spack

@buechlerm
buechlerm requested a review from Yurlungur November 16, 2026 13:14
Comment thread singularity-eos/eos/eos_mgusup.hpp Resolved
@buechlerm

Copy link
Copy Markdown
Collaborator Author

Not sure why this fails the ci tests, but I'll dive in when I get a chance.

@buechlerm
buechlerm merged commit 023ab71 into main Nov 17, 2026
10 checks passed
@buechlerm
buechlerm deleted the buechler/Davis_EofRP branch November 17, 2026 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants