Skip to content

Make prints in rootfinds portable - #665

Merged
Yurlungur merged 5 commits into
lanl:mainfrom
c-prather:cep/sycl-support
Oct 28, 2026
Merged

Yurlungur merged 5 commits into
lanl:mainfrom
c-prather:cep/sycl-support

Conversation

@c-prather

Copy link
Copy Markdown
Contributor

Replace printf with PortsOfCall::printf in the root finding code in Singularity EOS.

Requires ports-of-call to be updated with this before this is useful for SYCL support.

PR Checklist

  • Adds a test for any bugs fixed. Adds tests for new features.
  • Format your changes by using the make format command after configuring with cmake.
  • Document any new features, update documentation for changes made.
  • Make sure the copyright notice on any files you modified is up to date.
  • After creating a pull request, note it in the CHANGELOG.md file.
  • LANL employees: make sure tests pass both on the github CI and on the Darwin CI
  • If ML was used, make sure to add a disclaimer at the top of a file indicating ML was used to assist in generating the file.
  • If Agentic AI was used, have the AI generate a "proposed changes" markdown file and store it in the plan_histories folder, with a filename the same as the MR number.

If preparing for a new release, in addition please check the following:

  • Update the version in cmake.
  • Move the changes in the CHANGELOG.md file under a new header for the new release, and reset the categories.
  • Maintainers: ensure spackages are up to date:
    • LANL-internal team, update XCAP spackages
    • Current maintainer of upstream spackages, submit MR to spack

@Yurlungur Yurlungur left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these changes!

@Yurlungur Yurlungur added the bug Something isn't working label Oct 27, 2026
@Yurlungur Yurlungur self-assigned this Oct 27, 2026
@Yurlungur

Copy link
Copy Markdown
Collaborator

@c-prather can you push after applying formatting?

@c-prather

Copy link
Copy Markdown
Contributor Author

Done! Hopefully clang-format-19 has the same output, I don't still have easy access to 17.

This is going to need lanl/ports-of-call#122 still, so if that goes in I can add the submodule bump to this PR rather than opening a new one just for that

@Yurlungur

Copy link
Copy Markdown
Collaborator

thanks for the reminder! merged that one.

@c-prather

Copy link
Copy Markdown
Contributor Author

Bumped ports-of-call! Doesn't look like anything else important changed, hopefully it's a smooth vbump.

@Yurlungur
Yurlungur merged commit 4357231 into lanl:main Oct 28, 2026
10 checks passed
@Yurlungur

Copy link
Copy Markdown
Collaborator

We will need a new release of ports-of-call (and spiner) and singularity-eos when we update the spackage and do a new spack release. (Note to me.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants