lorenzo/start kw integration pr 1 - #198
Draft
lorenzoberts wants to merge 5 commits into
Draft
Conversation
This commit adds the crate features the process infrastructure needs to spawn long-running jobs, wait asynchronously, and kill a process group. Tokio gains process and time support, async-trait makes a running-process handle object-safe, and nix provides a safe killpg wrapper. This commit is part of the kw integration's step 1. Signed-off-by: lorenzoberts <lorenzobs@usp.br>
…p kill This commit introduces ProcessTrait as a separate infrastructure boundary from ShellTrait. Spawn returns immediately with a RunningProcess handle, streams stdout and stderr into a log file, and supports async wait plus process-group kill so long-running kw jobs cannot freeze the TUI or leak grandchild processes. This commit is part of the kw integration's step 1. Signed-off-by: lorenzoberts <lorenzobs@usp.br>
…tests This commit adds a test-only ProcessTrait double whose lifecycle a caller can hold open, finish, or kill. Each spawn is recorded so tests can assert argv, cwd, and log path without talking to a real process. This commit is part of the kw integration's step 1. Signed-off-by: lorenzoberts <lorenzobs@usp.br>
This commit hardens the process module after review. Kill tests wait for a real grandchild pid instead of racing an empty sidecar file, a failed spawn no longer leaves a truncated log behind, and the fake double treats terminal states as terminal so tests can simulate spawn failure faithfully. The module is unix-gated at declaration, matching kw's Linux-only process-group kill. This commit completes the kw integration's step 1. Signed-off-by: lorenzoberts <lorenzobs@usp.br>
lorenzoberts
force-pushed
the
lorenzo/start-kw-integration-pr-1
branch
from
August 20, 2026 21:01
d821033 to
2f980cb
Compare
…module This commit keeps the dead_code allowances the unused OsProcess surface still needs, but stops explaining them in terms of a later KwActor that is not in this change. This commit is part of the kw integration's step 1. Signed-off-by: lorenzoberts <lorenzobs@usp.br> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack created with GitHub Stacks CLI • Give Feedback 💬