Skip to content

Honor requested WebSocket protocol in muxed pod exec - #1965

Closed
brendandburns with Copilot wants to merge 2 commits into
masterfrom
copilot/fix-v5-websocket-issue
Closed

brendandburns with Copilot wants to merge 2 commits into
masterfrom
copilot/fix-v5-websocket-issue

Conversation

Copilot AI commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

MuxedStreamNamespacedPodExecAsync ignored the requested WebSocket subprotocol, opening V4 even when callers selected V5.

  • Option forwarding: Pass the subprotocol, stream flags, and custom headers to WebSocketNamespacedPodExecAsync.
  • V5 support: Enable channel-close support when the negotiated protocol is V5 binary; retain V4 as the default.
  • Regression coverage: Cover protocol selection, negotiated-protocol handling, and option forwarding.
using var demuxer = await client.MuxedStreamNamespacedPodExecAsync(
    podName,
    namespaceName,
    command: new[] { "/bin/sh" },
    webSocketSubProtocol: WebSocketProtocol.V5BinaryWebsocketProtocol);

Copilot AI balanced review requested due to automatic review settings October 16, 2026 20:05
@kubernetes-prow kubernetes-prow Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 16, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request. Check if the Files changed in this pull request are included in default exclusions.

@linux-foundation-easycla

linux-foundation-easycla Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

CLA Not Signed

@kubernetes-prow kubernetes-prow Bot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 16, 2026
Copilot AI linked an issue Oct 16, 2026 that may be closed by this pull request
Co-authored-by: brendandburns <5751682+brendandburns@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings October 16, 2026 20:09
@kubernetes-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Copilot
Once this PR has been reviewed and has the lgtm label, please ask for approval from brendandburns. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 16, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The focused fix preserves V4 defaults and includes regression coverage, with no blocking issues identified; tests were not executed during this review.

0 open findings

🧠 Review effort: Balanced

Copilot AI changed the title [WIP] Fix MuxedStreamNamespacedPodExecAsync to open V5 WebSocket Honor requested WebSocket protocol in muxed pod exec Oct 16, 2026
Copilot AI requested a review from brendandburns October 16, 2026 20:13
@brendandburns
brendandburns marked this pull request as ready for review October 16, 2026 20:27
@kubernetes-prow kubernetes-prow Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 16, 2026
@kubernetes-prow
kubernetes-prow Bot requested a review from tg123 October 16, 2026 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MuxedStreamNamespacedPodExecAsync doesn't open a V5 WebSocket

3 participants