test(byok): keep the operator-key leak test on the HTTP path under replay - #1052
Merged
Merged
Conversation
…play Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
Author
|
이 브랜치( |
3 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
문제
#1051 을 머지한 뒤
main의Cross-repo contract가 빨갛다 (run 37410221619,ecc75f5).그 잡은
KPUBDATA_REPLAY_DIR을 준다. 그러면 kpubdata 가 HTTP 대신 기록된 fixture 를 재생하므로, 이 테스트가 바꿔 끼운 소켓(httpx.Client.send)에 닿지 않는다. 이 워크플로는 경로 필터 때문에 #1051 의 PR 에서는 돌지 않았고, 내가 승인할 때 그 점을 보지 않았다.변경
fixture 에서
KPUBDATA_REPLAY_DIR을 지운다 —test_credential_hosts.py,test_canary_leak_gate.py가 같은 이유로 하는 것과 같다. 한 줄과 주석.검증
ruff check,ruff format --check통과.Cross-repo contract를 수동 실행했고 결과를 아래 코멘트에 붙인다.🤖 Generated with Claude Code