Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 931b413035
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if redact_errors: | ||
| self._send_or_close(task) | ||
| else: | ||
| self._send(task) |
There was a problem hiding this comment.
Fall back when detailed worker errors exceed the packet cap
For a non-redacted isolated or remote request, generated code can raise an exception whose string is larger than MAX_PROTOCOL_BYTES (for example, raise RuntimeError('x' * 20_000_000)). Encoding this _error task then raises instead of notifying the controller; the finally block still sends _close, after which the worker exits nonzero and the caller receives the misleading “exceeded its memory limit or exited unexpectedly” error rather than the actual runtime failure. Send a bounded fallback error when the detailed error cannot be encoded.
Useful? React with 👍 / 👎.
…coped-codemode-hardening # Conflicts: # docs/harness-sdk.md # hyperforge/src/hyperforge/harness_sdk/tools/codemode.py # hyperforge/tests/harness_sdk/test_codemode.py
|
Superseded by upstream internal PR nuclia#140 now that foundation PR nuclia#139 has merged. The upstream branch contains only the hardening delta against current |
Summary
0.0.0.0:8091, and server-owned limits remain unset unless configured.Testing
uv run --python 3.12 pytest tests/codemode/test_model.py tests/codemode/test_protocol.py tests/harness_sdk -q(251 passed, 1 skipped)make lintinhyperforgemake lintinagents/restricteduv run --python 3.12 pytest tests/test_sandbox.py -qinagents/restricted(16 passed)git diff --checkStack
Depends on upstream foundation PR nuclia#139. This PR targets the matching foundation branch in the contributor fork so the hardening delta remains independently reviewable. Once the foundation merges, this branch can be proposed directly against upstream
main.