Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserves backward compatibility for existing
agents/restricteddeployments while retaining the scoped Code Mode hardening introduced by nuclia#119.Architecture
SandboxRunner.with_pool(), which is the legacy local execution path used by the restricted agent.Backward Compatibility
bytes, sets, dataclasses, and domain objects through local process-pool execution.SANDBOX_MAX_CONCURRENT_SESSIONS,SANDBOX_MAX_SESSION_RUNTIME_SECONDS, orSANDBOX_MAX_SESSION_MEMORY_BYTESis explicitly configured.0.0.0.0:8091by default. Deployments can opt into the hardened behavior withSANDBOX_METRICS_ENABLED=falseorSANDBOX_METRICS_HOST=127.0.0.1.Validation
Adds a real
ProcessPoolExecutorintegration test that exercises a legacybytesvalue across both sides of restricted-agent callback IPC, plus assertions protecting the compatibility defaults.This PR is stacked on nuclia#119 and targets its source branch.