Update plugin for proto v0.60 - #11
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the Zig proto plugin to be compatible with proto v0.60 by upgrading the proto PDK/test utilities and aligning plugin API usage (version spec + host env) with the updated schema and conventions.
Changes:
- Bump proto compatibility (
minimum_proto_version) to0.60.0and update PDK usage (Default::default(),check_supported_os_and_archcall shape,VersionSpec::Versionpattern). - Adjust version/build handling to the new
build: Option<_>representation (is_some()checks). - Refresh test expectations and shim registry snapshot to the v0.60 schema.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/proto.rs |
Updates minimum proto version and adapts to new host env + version spec/build metadata APIs. |
tests/versions_test.rs |
Updates master alias assertion for new build metadata representation. |
tests/snapshots/shims_test__creates_shims.snap |
Updates shim registry snapshot keys/shape to match v0.60 schema. |
Cargo.toml |
Bumps crate/plugin version and updates proto PDK + dev dependency versions. |
Cargo.lock |
Lockfile refresh reflecting upgraded dependency graph for v0.60 compatibility. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The previous WASM was built against an older PDK context shape. When loaded by proto v0.60, plugin calls could fail while deserializing the context with
missing field tool_dir.This also includes the proto v0.59-era
VersionSpec::SemantictoVersionSpec::Versionmigration required before applying the v0.60 changes.Impact
The newly built WASM requires proto 0.60.0 or newer. Zig release versions and master/canary builds continue to resolve and install through the same plugin interface.
Validation
cargo fmt --all --checkcargo clippy --workspace --all-targetsPROTO_LOOKUP_DIR=/opt/homebrew/bin cargo test --no-default-features(26 tests passed)cargo build --release --target wasm32-wasip1proto 0.60.2:proto versions zig-test