Scale multirotor rank validation - #347
Open
be-student wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Fixes #301 by replacing the mixer rank check’s fixed
1e-4threshold with a forward-error bound derived fromT::EPSILON, the multiplication dimension, and‖A‖‖A⁺‖. The bound is capped below the order-one residual produced by a missing control direction.Tests reproduce the prior precision mismatch with a valid layout whose moment rows are scaled by
100,000×, then prove acceptance at bothf32andf64; a rank-deficient layout remains rejected at both precisions. The constructor docs and changelog describe the scale-aware contract. This contribution was implemented with AI assistance and reviewed through the repository's test and lint gates.Checklist
cargo test+cargo clippy --all-targetsclean locallyunwrap/expect/panicon library paths (typed errors instead)