Makefile: bump CODE_GENERATOR_IMAGE to release-1.34, fix deepcopy-gen/openapi-gen invocations - #648
Merged
Merged
Conversation
…/openapi-gen invocations for the new CLI CODE_GENERATOR_IMAGE was still pinned to release-1.32. Both deepcopy-gen and openapi-gen changed their CLI in the newer toolchain this bumps to: deepcopy-gen dropped --input-dirs/--output-file-base for positional package args + --output-file; openapi-gen dropped --input-dirs/ --output-package for positional package args + --output-dir/ --output-pkg/--output-file. deepcopy-gen's output is byte-identical to what was already checked in (verified by diffing before/after). openapi-gen's output picks up five type schemas (CAPIClusterInfo, ClusterClaimFeatures, ClusterClaimInfo, ClusterInfo, TypeReference) that already existed in api/v1 but were missing from the checked-in openapi_generated.go, plus two stale doc comments -- api/v1/openapi_generated.go was already out of date before this change; 'openapi' isn't wired into the 'gen' target here (matches this repo's existing composition, left as-is), so nothing was regenerating it. Not otherwise exercised by verify-gen (which only runs 'gen fmt', i.e. clientset + gen-enum, not openapi). Verified with make check-license, lint, build, and verify against the real gengo-builder release-1.34 image. Signed-off-by: Tamal Saha <tamal@appscode.com>
![kodiakhq[bot]](https://avatars.githubusercontent.com/in/29196?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CODE_GENERATOR_IMAGEwas still pinned torelease-1.32. Bothdeepcopy-genandopenapi-genchanged their CLI in the newer toolchain this bumps to:deepcopy-gendropped--input-dirs/--output-file-basefor positional package args +--output-file.openapi-gendropped--input-dirs/--output-packagefor positional package args +--output-dir/--output-pkg/--output-file.deepcopy-gen's output is byte-identical to what was already checked in.openapi-gen's output picks up five type schemas (CAPIClusterInfo,ClusterClaimFeatures,ClusterClaimInfo,ClusterInfo,TypeReference) that already existed inapi/v1but were missing from the checked-inopenapi_generated.go, plus two stale doc comments -- it was already out of date before this change.openapiisn't wired into thegentarget here (left as-is, matches existing composition), so nothing was regenerating it; not exercised byverify-geneither.Verification
Ran locally against the real
ghcr.io/appscode/gengo:release-1.34image:make verify(verify-gen + verify-modules),check-license,lint,build-- all pass.