Fix flash alert overlapping login form on auth pages - #653
Draft
tungleduyxyz wants to merge 5 commits into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to prevent flash/server alert banners from overlapping the vertically centered login (and similar auth) forms by changing how .centered-absolute alerts are positioned on auth-related pages.
Changes:
- Adds an auth-page-specific CSS override intended to render
.centered-absoluteflash/alert banners in normal document flow (instead of absolute positioning), so the alert pushes the auth form down.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| positioned alert can overlap it depending on viewport size. Render it in | ||
| normal flow here instead, so it pushes the form down rather than | ||
| overlapping it. */ | ||
| .auth-container .centered-absolute { |
Reposition the .centered-absolute flash alert to render in normal document flow on auth pages, so it pushes the vertically-centered login/wallet re-authentication card down instead of overlapping it. Related to #652
Rescue KillBillClient::API::ResponseError when fetching bundles in AccountsController#show (e.g. a subscription references a plan no longer present in the currently loaded catalog). Instead of a 500, show a non-blocking warning and render the rest of the account page with an empty bundles list. Related to #651
Add overflow: hidden to .auth-container so the alert's top margin doesn't collapse through the container and expose the page's body background above it. Related to #652
Add a 'Group by' dropdown (Object Type / Date) on the account timeline page. Sorting by date uses a new timeline_sort_timestamp helper to derive a best-effort epoch timestamp per entry (invoice target date, transaction/event effective date), falling back to the original grouped-by-type DOM order otherwise. Entries without a usable timestamp sort last. Existing search/type filters still apply after re-sorting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #652, #651.
.centered-absoluteflash alert so it renders in normal document flow on auth pages, pushing the vertically-centered login/wallet re-authentication card down instead of overlapping it.Note: opening as draft, there are still a few more related issues to address - more commits coming to this PR.