Repository navigation
feat: start new modules on the lazy web component contract - #21
Open
AndrewKirkovski wants to merge 2 commits into
Open
AndrewKirkovski wants to merge 2 commits into
AndrewKirkovski wants to merge 2 commits into
Conversation
EE2-2752. The template keeps registration eager and loads its implementation
through a dynamic import, with Host import map externals. A failed or stalled
load shows wippy-error and emits { message, error }.
6 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and resulting behavior
New modules started from the old eager entry, and the template gate required
preserveEntrySignatures: false, which drops thewebComponentexport that factory loading needs.The template now keeps registration eager and loads its implementation through a dynamic import, with externals from a pinned Host import map snapshot. A failed or stalled load shows
wippy-errorand emits{ message, error }.scripts/check-module.mjsenforces the new build settings and rejects a bundle that imports a package the Host does not map.Validation
node scripts/check-module.mjs,npm run type-check,npm run buildand the 3 UI tests pass.node scripts/test-initializer.mjspasses. It skips any path under a.localfolder, so it ran from a copy outside one.Checklist