Add audit-logs export commands for S3 export destinations - #214
Draft
yummybomb wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
kernel audit-logs exportcommand group for managing S3 audit log export destinations:create— creates a destination (paused by default) and prints the trust-policy onboarding steps with the Kernel role ARN and external IDlist— paginated table with delivery status per destination (--limit/--offset, more-results hint from pagination headers)get— full detail view including delivery status: status, last success with computed lag, last error and time, consecutive failures, next attemptupdate— partial update of region/bucket/prefix/role ARN/KMS key;--clear-kms-keysends an empty string to remove the key, omitted flags leave fields unchanged; 409 conflicts get a retry-against-fresh-state hintpause/resume— status transitions with notes on in-flight uploads and resume semanticsdelete— removes a destinationtest— runs the destination test and exits non-zero on failure, reporting the failing stage and error codeThese endpoints have no generated SDK surface, so the command defines local request/response types and calls them through the raw
kernel.Clientrequest methods, following the existingcmd/audit_logs.goservice-interface pattern. All subcommands support--output json.Testing
make testpasses (27 new table-driven unit tests with a fake service, covering output rendering, flag validation, partial-update/clear semantics, pagination hints, 409 handling, and test-failure exit behavior)