Repository navigation
fix(web): Move to Trash never disappears from the selection bar - #544
Merged
Merged
Conversation
It was the bar's one action loaded on demand, and a failed load (Kept updated while the page was open) drew nothing, until a reload. Now it always shows: off while it loads, off with Reload beside it when its load failed, and fetched again on the next selection or when the connection comes back, as Set a field does. Closes #543. Signed-off-by: Ibrahim Roshdy <22573766+ibrahimroshdy@users.noreply.github.com>
ibrahimroshdy
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move to Trash could vanish from the selection bar: it is the bar's one action loaded on demand, and a failed load (Kept updated while the page or installed app was open) drew nothing until a reload. Reported in discussion #183.
Closes #543.
components/things/bulk-trash-lazy.tsx, on the same retry pattern as "Set a field…" (list-bulk-lazy.tsx): the button always shows. Off while it loads; off with Reload beside it when its load failed; fetched again on the next selection or when the connection comes back.contents-list.tsxuses it in place of the lazy import that fell back to nothing.Definition of done
bulk-trash-lazy.test.tsx(a failed load shows the button off with Reload, and the next mount loads the real one), written first and seen failing;browse.test.tsxgains Move to Trash for things selected inside a box, the case in the report. Browse, list-bulk-lazy and the new test: 79 pass. Lint, catalogues and typecheck green.KEPT_*settings: n/a.