Repository navigation
fix(places): the tree's header keeps the location's name in whole words - #539
Open
ibrahimroshdy wants to merge 1 commit into
Open
ibrahimroshdy wants to merge 1 commit into
ibrahimroshdy wants to merge 1 commit into
Conversation
At its narrowest the place tree left the location's name a few characters
beside Fold all, so it broke a letter or two per line, worse in German
("Alle einklappen"). The name and the button now wrap as a pair, as the
box rows do since #431: the button goes under the name, at its start, when
both don't fit, and the name keeps the line.
The e2e spec checks it at 208 px in German and Arabic, as wide as it goes in
English, and the outline's Fold all at 375 px.
Fixes #462
Signed-off-by: Ibrahim Roshdy <22573766+ibrahimroshdy@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The place tree's header kept breaking the location's name letter by letter when the tree was narrow, next to Fold all (worse in German, "Alle einklappen").
Closes #462.
The header row now wraps and the name sizes to its full width first (
flex-auto), so when the name and the button don't fit on one line the button goes under the name, lined up with its start, and the name keeps whole words. The same approach #431 took for box rows. No new strings.Definition of done
apps/web/e2e/place-tree-header.spec.ts, seen failing first ("Home", "Street" and "desktop" split mid-word): no word split, the button on one line inside the panel, nothing overflowing, in German at 208 px (Fold all and Open all), English at the widest width, Arabic mirrored at 208 px, and the German outline at 375 px, with axe.place-tree-names,place-tree-widthandplaces-foldstill pass. Fast gate green.KEPT_*settings: n/a.