Repository navigation
Support VHDL loop control and IEEE logic conversions - #546
Merged
Merged
Conversation
Merging this PR will not alter performance1 warning
Comparing |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runtime VHDL functions and processes previously rejected
exitandnextinside static-range loops. This change unrolls those loops with merged loop and iteration activity flags, so transfers guard later variable updates and scheduled signal assignments. It also handles branches that mix loop transfers with function returns.The frontend now accepts null internal array signals and variables without creating physical nets, lets architecture constants hide imported package constants, and lowers the IEEE
to_bit,to_stdulogic,to_bitvector,to_stdlogicvector, andto_stdulogicvectorconversions. Conversion handling checks named arguments and types, normalizes vector result bounds, and folds explicit metavalues throughxmap. Synthetic regressions and loading documentation cover the resulting behavior.Validation
ctest --test-dir build -L determinism --no-tests=error --output-on-failure: passed, including new cross-process coverage of loop transfers, null arrays, constant hiding, conversions, live state, dumps, and snapshot round trips.'-'assignment.git diff --check: passed. Bazel validation was not run.Follow-up
Selected assignments still elaborate a metavalue-only
othersalternative even when explicit alternatives cover every binary selector value. That handling, and the representation policy for a reachable VHDL'-', remain deferred. A follow-up should investigate general binary-domain coverage analysis with diagnostics for its assumptions, preserve explicit X/Z cases and rejection of unsupported reachable values, and add synthetic and formal regressions before changing lowering.