Repository navigation
Fix VHDL scalar type conversions and logic-vector visibility - #544
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Merging this PR will not alter performance1 warning
Comparing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scalar VHDL type conversions such as
std_logic(a_i)now resolve visible type and subtype marks and preserve values and nominal enumeration identity. Logic-vector conversions usestd_logic_1164without requiringnumeric_std; signed and unsigned type marks retain their numeric-package visibility checks. Constrained vector subtype conversions preserve positional mapping and validate lengths.Adds scalar and vector fixtures with direct connectivity checks through the C++ constructor and Python
NLDB.loadVHDL, plus coverage for reverse conversions, scalar subtypes, user-defined enumeration identity, ascending vector bounds, and invalid conversions. Updates the loading guide.Validation:
reuse lintandgit diff --checkpassed.