Skip to content

Fix VHDL scalar type conversions and logic-vector visibility - #544

Merged
xtofalex merged 1 commit into
mainfrom
fix/vhdl-type-conversions
Nov 19, 2026
Merged

xtofalex merged 1 commit into
mainfrom
fix/vhdl-type-conversions

Conversation

@xtofalex

Copy link
Copy Markdown
Collaborator

Scalar VHDL type conversions such as std_logic(a_i) now resolve visible type and subtype marks and preserve values and nominal enumeration identity. Logic-vector conversions use std_logic_1164 without requiring numeric_std; signed and unsigned type marks retain their numeric-package visibility checks. Constrained vector subtype conversions preserve positional mapping and validate lengths.

Adds scalar and vector fixtures with direct connectivity checks through the C++ constructor and Python NLDB.loadVHDL, plus coverage for reverse conversions, scalar subtypes, user-defined enumeration identity, ascending vector bounds, and invalid conversions. Updates the loading guide.

Validation:

  • All 274 CMake VHDL constructor tests passed.
  • All 18 VHDL-related raw Python NLDB tests passed.
  • Sphinx HTML build passed with the built-in Alabaster theme.
  • reuse lint and git diff --check passed.
  • Bazel validation was blocked before the test target built: Bison runfiles compilation rejected an absolute inclusion of Xcode's SDKSettings.json. Build-path parity remains unverified locally.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@codspeed

codspeed Bot commented Nov 19, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

1 warning

⚠️ 13 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

✅ 111 untouched benchmarks


Comparing fix/vhdl-type-conversions (e03cfb6) with main (c9563f3)

Open in CodSpeed

@xtofalex
xtofalex merged commit f1db5dd into main Nov 19, 2026
119 of 122 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants