Repository navigation
Reduce SV case-local packed replay mux allocations - #543
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Merging this PR will not alter performance1 warning
Comparing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Case replay previously materialized complete packed local values at every arm merge, leaving repeated common-arm muxes for the post-load cleanup. Extend the case-local scalar accumulator to complete integral values using declared width and whole-write eligibility. Keep arm/selector/item/guard evaluation eager, pending values outside active replay environments and caches, and materialization at incompatible merges and each case exit.
Partial writes, subroutine copy-outs, scheduling replay, active loops and uncertain effects retain conservative fallbacks. Both frontend cleanup calls remain enabled; VHDL lowering and primitive semantics are unchanged.
Measured against
c9563f30(#542):Validation:
Validation limits: source-based Bazel selected matching dependencies but executed zero tests, blocked by the local Xcode SDK absolute include check for
SDKSettings.json. Four historical stress inputs were unavailable, limiting measurements to nine workloads; the regenerated Ibex file list has a different byte hash, while all 235 other available historical source/include hashes match. CMake/Bazel parity remains unverified.Details: implementation, measurements and limits.