Repository navigation
Audit readiness to remove frontend mux cleanup - #540
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Merging this PR will not alter performance1 warning
Comparing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both frontend calls to
SNLUtils::mergeRepeatedMuxSelectionsstill perform material mux reduction after #535/#536. This report-only audit records direct allocation/pass measurements on mainc968cf72, classifies the residual lowering boundaries, and compares an isolated calls-disabled variant without changing production behavior.Direct cleanup removes 383 muxes / 951 output bits from public Ibex and 18 / 340 from public VHDL AES. Disabling the calls retains those muxes while leaving total instance counts unchanged. Keep both calls enabled. The smallest proposed follow-up is case-local scalar SV replay accumulation; 207 observed case-to-case removals are an opportunity ceiling, not promised coverage. VHDL residuals and utility deletion remain separate assessments. No optimization is implemented here.
Evidence includes repeated folded and hierarchy-expanded counts, per-design pass totals, classified merges, and all 208 uninstrumented timing samples. Timing is exploratory: ranges are wide and controls noisy. All 240 corpus input/source/include hashes match the established public/synthetic configurations. No confidential inputs, raw source copies, diagnostic patches or binary archives are included.
Validation:
reuse lintandgit diff --checkpass.See the audit report for methods, limitations and the evidence required before removal.