Repository navigation
Compare strings, not only hash keys, in addnode() - #525
Merged
Merged
Conversation
addnode() treated any existing node with the same DJBHash value as a duplicate, so a string whose hash collides with an already stored one was silently dropped. DJBHash collisions are trivial to craft (eg. "az" and "bY"), so a crafted MIME boundary could prevent another boundary from being stored, and colliding IMAP folder names would cause a folder to be skipped during import. Check the stored string with strcmp() as findnode() already does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
addnode()(src/hash.c) treated any existing node with the same DJBHash value as a duplicate. A new string whose hash collides with one already stored was silently dropped.findnode()compares the actual strings, so the two functions disagree.DJBHash collisions are trivial to craft (e.g.
"az"and"bY"). Impact per caller:rcpt,rcpt_domain,journal_recipient): no real impact. Callers check duplicates withfindnode()and append the address regardless.Follow-up to #524 (raised by an automated security review of that PR).
Fix
Also compare the stored string with
strcmp()before treating a node as a duplicate.Testing
test_addnode_collision()inunit_tests/check_hash.c. It fails on master and passes with this change.check_parser, pass insutoj/builder:resolute.🤖 Generated with Claude Code