Repository navigation
Report a request timeout as HttpTimeoutException - #36
Merged
Merged
Conversation
added 2 commits
October 8, 2026 13:40
java.net.http raises HttpTimeoutException "request timed out" when a response's headers don't arrive within HttpRequest.timeout. The shim let the socket's SocketTimeoutException through, so callers classifying a timeout by class or by babashka.http-client's "timed out" wording missed it (jolt-lang/jolt#1282).
check-deadline! reported the set-max-response-ms! cap whenever one was set, even when the sooner request deadline was the one that fired. Under a cap, a request timeout then read as the total time limit and request-timeout-ex left it a SocketTimeoutException. effective-deadline now records which bound is in force.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
java.net.http raises HttpTimeoutException "request timed out" when the response headers don't arrive within HttpRequest.timeout. The shim let the transport's SocketTimeoutException through instead ("Read timed out", or "Response exceeded the request timeout" from the deadline check), so callers that classify a timeout by class or by the "timed out" wording missed it. The cap from set-max-response-ms! keeps its own message.
The body-stall half of jolt-lang/jolt#1282 (an SSE idle watchdog losing to the request timeout) is the #26 behaviour, fixed in #27 and shipped since v0.0.14: the request timeout stops at the headers. A project pinned before v0.0.14 still sees it.
Fixes jolt-lang/jolt#1282.