Skip to content

⚡ optimize path reconstruction in Dijkstra.Solve - #184

Merged
johnstrand merged 1 commit into
masterfrom
jules-7364392726106216265-9443bd56
Sep 12, 2026
Merged

johnstrand merged 1 commit into
masterfrom
jules-7364392726106216265-9443bd56

Conversation

@johnstrand

Copy link
Copy Markdown
Owner

💡 What: Optimized path reconstruction in Dijkstra.Solve by populating path directly in reverse order using path.Add(current) and reversing it with path.Reverse() instead of constructing an intermediate Stack<T> and enumerating it into a new List<T>.

🎯 Why: Creating a Stack<T> and initializing a List<T> from it causes unnecessary stack array allocation and copy overhead during stack enumeration.

📊 Measured Improvement:
In a 50x50 grid benchmark, memory allocations per operation dropped from 65.27 KB to 63.1 KB (reducing allocations by ~2.17 KB per call). Mean execution time remained optimal at ~839.6 µs.


PR created automatically by Jules for task 7364392726106216265 started by @johnstrand

Co-authored-by: johnstrand <11484777+johnstrand@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@johnstrand
johnstrand merged commit 57ef1c8 into master Sep 12, 2026
1 check passed
@johnstrand
johnstrand deleted the jules-7364392726106216265-9443bd56 branch September 12, 2026 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant