fix(terminal): increase wheel scroll sensitivity - #257
Merged
johannesjo merged 3 commits intoAug 14, 2026
Merged
Conversation
fastScrollSensitivity: 5 is already xterm's default, so setting it was a no-op; Alt-scroll compounds with scrollSensitivity to 20 lines per notch either way. Inline TERMINAL_SCROLLBACK_LINES, which no longer had any consumer outside this file, and drop the test that only restated the constant's literal value.
4 lines per wheel notch overshoots badly on a normal mouse; 2 is a comfortable middle between xterm's default of 1 and the 3-5 range requested in johannesjo#254. Wheel resolution varies enough between devices that a tunable setting is the real fix - johannesjo#254 stays open for that.
Owner
|
Thank you very much! <3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
npm run test:unit -- src/lib/terminalConstants.test.tsnpm run checknpm run check:staticnpm test(1,805 unit tests and 9 client tests passed)npm run build:frontendnpm run build:remoteCloses #254