Repository navigation
chore: upgrade LSP libraries to vscode-languageserver / languageclient 10 - #261
Merged
Merged
Conversation
…t 10 server: - vscode-languageserver 8.0.0-next.8 (pre-release) -> 10.x - Import only from the public vscode-languageserver/node entry point instead of internal lib/ paths, which the new exports map no longer allows - Drop direct vscode-jsonrpc / vscode-languageserver-protocol deps and the unused vscode-languageclient dependency client (VS Code extension): - vscode-languageclient 7 -> 10, which requires VS Code ^1.91.0 - Replace removed onReady() with awaiting start(); register notification handlers before start() so finishSetup is not missed - Add deactivate() that stops the client - Remove unused vscode-test dependency - Type-check the client in pnpm typecheck (it was only bundled by esbuild)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 4 of the maintenance plan: upgrade the LSP stack. The latest stable line is now 10.x (LSP 3.18), so this goes straight there instead of 9.x.
server (
sql-language-server)vscode-languageserver8.0.0-next.8(pre-release) ->^10.1vscode-languageserver/nodeentry point. The previous deep imports (vscode-languageserver/lib/node/main,vscode-jsonrpc/lib/node/main,vscode-languageserver-protocol/lib/common/protocol) are blocked by the newexportsmap.vscode-jsonrpc/vscode-languageserver-protocoldeps and the unusedvscode-languageclientdependencyclient (VS Code extension)
vscode-languageclient7 -> 10. Requires VS Code 1.91+ (engines.vscode: ^1.91.0,@types/vscode ~1.91.0)onReady()was removed in languageclient 8:activatenow returnsclient.start(), and notification handlers are registered before start so thefinishSetupnotification sent right after initialization is not misseddeactivate()that stops the clientvscode-testdependencypnpm typecheck(it was previously only bundled by esbuild)Test plan
releasebuild, for both a syntax-error document and a lint-error document with a fix code actionvscodeExtensionServer.jsanswersinitializeover node-ipc (the transport VS Code uses)