Skip to content

chore: upgrade LSP libraries to vscode-languageserver / languageclient 10 - #261

Merged
joe-re merged 1 commit into
releasefrom
chore/upgrade-lsp
Sep 25, 2026
Merged

joe-re merged 1 commit into
releasefrom
chore/upgrade-lsp

Conversation

@joe-re

@joe-re joe-re commented Sep 25, 2026

Copy link
Copy Markdown
Owner

Summary

Phase 4 of the maintenance plan: upgrade the LSP stack. The latest stable line is now 10.x (LSP 3.18), so this goes straight there instead of 9.x.

server (sql-language-server)

  • vscode-languageserver 8.0.0-next.8 (pre-release) -> ^10.1
  • Imports only from the public vscode-languageserver/node entry point. The previous deep imports (vscode-languageserver/lib/node/main, vscode-jsonrpc/lib/node/main, vscode-languageserver-protocol/lib/common/protocol) are blocked by the new exports map.
  • Removed direct vscode-jsonrpc / vscode-languageserver-protocol deps and the unused vscode-languageclient dependency

client (VS Code extension)

  • vscode-languageclient 7 -> 10. Requires VS Code 1.91+ (engines.vscode: ^1.91.0, @types/vscode ~1.91.0)
  • onReady() was removed in languageclient 8: activate now returns client.start(), and notification handlers are registered before start so the finishSetup notification sent right after initialization is not missed
  • Added deactivate() that stops the client
  • Removed the unused vscode-test dependency
  • The client is now type-checked in pnpm typecheck (it was previously only bundled by esbuild)

Test plan

  • build / lint / typecheck / vsc-compile / all tests on Node 22 (server 119 passed, parser 68, sqlint 36)
  • Scripted LSP session over stdio (initialize -> didOpen -> publishDiagnostics -> completion -> codeAction -> shutdown) produces byte-identical results against the current release build, for both a syntax-error document and a lint-error document with a fix code action
  • vscodeExtensionServer.js answers initialize over node-ipc (the transport VS Code uses)
  • Manual check in VS Code (F5 "Launch Client"): completion, diagnostics, "Switch database connection", "Fix all auto-fixable problems"

…t 10

server:
- vscode-languageserver 8.0.0-next.8 (pre-release) -> 10.x
- Import only from the public vscode-languageserver/node entry point instead
  of internal lib/ paths, which the new exports map no longer allows
- Drop direct vscode-jsonrpc / vscode-languageserver-protocol deps and the
  unused vscode-languageclient dependency

client (VS Code extension):
- vscode-languageclient 7 -> 10, which requires VS Code ^1.91.0
- Replace removed onReady() with awaiting start(); register notification
  handlers before start() so finishSetup is not missed
- Add deactivate() that stops the client
- Remove unused vscode-test dependency
- Type-check the client in pnpm typecheck (it was only bundled by esbuild)
@joe-re
joe-re merged commit f5fb158 into release Sep 25, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant