Repository navigation
chore: update sql-parser and sqlint dependencies (peggy 5, ajv 8, js-yaml 4) - #260
Merged
Merged
Conversation
peggy is only needed to generate base/*.js at build time. The generated parsers keep throwing errors named 'SyntaxError' with the same expected / location shape, which the server relies on.
- ajv 6 -> 8: remove options that no longer exist (schemaId, missingRefs) - js-yaml 3 -> 4: safeLoad was removed; load is safe by default - Replace chalk with node:util styleText - Report the unexpected property name in config validation errors. It used to read error.data.invalidProp, which only matched the test fixture, and printed "undefined" for other kinds of errors - Declare engines.node (^22.13.0 || >=24) on published packages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 3 of the maintenance plan: update the dependencies of
@joe-re/sql-parserandsqlint.sql-parser
devDependencies(only used to generatebase/*.js)base/parser.jsandbase/fromClauseParser.js. The committed files were confirmed to be identical to a fresh peggy 3 build, so the diff is purely the generator change.fromClauseParser.jsshrinks because peggy 5 no longer emits rules unreachable from the allowed start rule.SyntaxErrorwith the sameexpected/locationshape, whichcreateDiagnosticsand completion rely onsqlint
safeLoad->load)node:utilstyleText(one less dependency)invalidProp(only matched the test fixture) andundefinedfor other error kinds. They now print the unexpected property name / ajv message.bin/cli.jsPackaging
engines.node: "^22.13.0 || >=24"on the root and published packages (styleTextis stable from 22.13 / 23.5)Test plan
sqlint --stdinwith a YAML config applies the configured rulesUnexpected property "rulez"FORCE_COLOR=1