Skip to content

Run the tests under jolt; README says only serve needs bb - #5

Merged
burinc merged 4 commits into
jlt-commons:mainfrom
yogthos:fix/readme-jolt-test
Nov 18, 2026
Merged

burinc merged 4 commits into
jlt-commons:mainfrom
yogthos:fix/readme-jolt-test

Conversation

@yogthos

@yogthos yogthos commented Nov 9, 2026

Copy link
Copy Markdown
Member

The README said test and serve need bb because jolt doesn't bundle clojure.test. It does. What actually stopped the tests was cheshire (bb-only), a direct call to a private fn, and jolt-lang/time v0.0.9, whose locale-data docstring has an unescaped quote that jolt 0.8.25 rejects. That last one also broke jolt run build.

The time pin moves to the commit with the fix (no tag has it yet), the tests use clojure.data.json, and the README and info text now say only serve is bb-only (http-kit). jolt test and bb test both pass, 110 tests; jolt run build works again. Also drops the comments describing a site.serve.jolt twin that was never committed.

yogthos and others added 4 commits November 9, 2026 18:00
jolt-lang/time v0.0.9 has an unescaped quote in a docstring that jolt
0.8.25 rejects, which broke every task under jolt, build included. Pin
the commit that fixes it. The tests read JSON with cheshire, which only
bb bundles, so they use clojure.data.json now, and the one call to a
private fn goes through its var, as Clojure requires.
jolt does bundle clojure.test. The real reason serve is bb-only is
http-kit. The site.serve.jolt twin the comments described never existed.
clojure.data.json isn't bundled in babashka 1.13.220, so bb test failed
to load site.core-test. jolt test already passes with cheshire on main,
so the swap isn't needed for the tests to run under jolt.
@burinc

burinc commented Nov 18, 2026

Copy link
Copy Markdown
Member

Thanks! v0.4.5 and v0.4.6 already shipped the time pin (at a later commit, 06dfc4e) and the #'md/split-before-h2-headings call, so I merged main in and kept those.

I also put cheshire back in the two tests. babashka 1.13.220 doesn't bundle clojure.data.json, so bb test couldn't load site.core-test, and jolt test already passes with cheshire. The README, bb info and comment changes are as you wrote them. bb test and jolt test both pass (111 tests, 293 assertions) and jolt run build works.

@burinc
burinc merged commit dd57b20 into jlt-commons:main Nov 18, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants