Repository navigation
ci: run the tests and a build under jolt as well as bb - #11
Merged
Merged
Conversation
The README says build, clean and test run under jolt, but CI only ran bb, so a jolt break (like the time pin before v0.4.5) stayed green. The job now installs jolt 0.8.27, runs jolt test, and builds a base-pathed fixture with jolt run build. workflow_dispatch takes a jolt-version to try another release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README says
build,cleanandtestrun under jolt, but CI only installed bb. A jolt-only break could stay green, which is what happened with the jolt-lang/time pin before v0.4.5.The job now installs jolt 0.8.27 (the latest release) with the same install script ebb uses, then runs
jolt testand builds a small fixture withjolt run build. The build step checks that the guide page exists and that its stylesheet link keeps the/jolt-projectbase path. I ran that step locally first, and it passes.The jolt version is pinned so an overnight jolt change can't turn an unrelated PR red.
workflow_dispatchtakes ajolt-versioninput to try another release.