Skip to content

test(observability): scope the no-log assertion to the scrape route #651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jjjermiah merged 1 commit into from
Nov 11, 2026
Merged

test(observability): scope the no-log assertion to the scrape route #651

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion test/http/observability.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,9 @@ describe("#56 GET /plugboard/metrics", () => {
test("a successful scrape writes no log line", async () => {
await route({ metrics: true })
await server!.send({ path: "/plugboard/metrics" })
expect(logs.lines).toEqual([])
// Only lines about this scrape count. A background line from an earlier test (e.g. a streamed
// request's usage_missing) can land after beforeEach clears the capture, so filter on the route.
expect(logs.lines.filter((line) => line.raw.includes("/plugboard/metrics"))).toEqual([])
})

test("off: the route records no metrics at all", async () => {
Expand Down
Loading