Repository navigation
chore(deps): update BOM, parent POM, nixpkgs and CLI scanner to 1.30.1 - #175
Closed
tembleking wants to merge 1 commit into
Closed
tembleking wants to merge 1 commit into
tembleking wants to merge 1 commit into
Conversation
Bumps bouncycastle-api to pull Bouncy Castle 1.85.2, fixing a Name Constraints bypass (critical) and an ASN.1 nesting-depth guard reset (high). The plugin ships BC transitively via credentials, so it lands on every controller that installs it. Also removes IaCScanningBuilder#doCheckCredentialsId. No form field is bound to it (the UI uses engineCredentialsId), but it was still reachable by URL and looked credentials up as SYSTEM without a permission check, letting any user with Overall/Read probe which credential IDs exist.
tembleking
requested review from
Jujuyeh,
airadier,
alecron and
mateobur
as code owners
September 24, 2026 13:48
tembleking
enabled auto-merge (squash)
September 24, 2026 13:49
Collaborator
|
The version bumps look clean and consistent across code, README, tests, and fixtures. However, this deps PR also drops the doCheckCredentialsId form validation and its imports, which seems out of scope. Could you confirm that removal is intentional, or split it into its own change? |
Member
Author
|
Yes, it's intentional. No form field binds to |
auto-merge was automatically disabled
October 14, 2026 11:51
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The plugin ships Bouncy Castle transitively through
credentials→bouncycastle-api, so the 1.84 copy landed on every controller that installs it. Bumping the BOM pulls BC 1.85.2, which fixes a Name Constraints bypass (critical) and an ASN.1 nesting-depth guard reset (high).This also drops
IaCScanningBuilder#doCheckCredentialsId. No form field is bound to it (the UI usesengineCredentialsId), but it was still reachable by URL and looked up credentials as SYSTEM without a permission check, letting any user with Overall/Read probe which credential IDs exist.The remaining Spring and jenkins-core alerts come from core (
providedscope). The plugin doesn't ship them; they get fixed by upgrading Jenkins itself.