Repository navigation
Keep user pages navigable when profile metadata is blocked - #5
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Reddit blocks
/user/<name>/about.json, Redlib currently substitutes an entirely empty user. This blanks the profile box and generates tab links such as/user//submitted, which are interpreted as another username and return Forbidden.Preserve the requested username on metadata errors so overview/comments/submitted navigation and follow/filter actions stay correctly addressed. Show an explicit unavailable message and hide unknown profile details rather than presenting zero karma or an empty image. Log the metadata failure for diagnosis; history-fetch errors retain existing handling.
Add rendered-template regression tests for blocked metadata, valid tab/action URLs, and available metadata including genuine zero karma. No deployment configuration or dependencies change.
Validation: all 66 offline tests pass locally and in hosted Linux CI. Hosted formatting, Clippy with warnings denied, and complete test-suite compilation also pass.