Skip to content

perf: collect relationship projection fields during query construction #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jechol wants to merge 1 commit into
base: main
Choose a base branch
from
Open

perf: collect relationship projection fields during query construction #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions lib/aggregate.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ defmodule AshSql.Aggregate do
def add_aggregates(query, aggregates, resource, select?, source_binding, root_data) do
with {:ok, query, aggregates} <-
AshSql.Aggregate.Common.normalize(query, aggregates, resource, root_data) do
query = track_projection_sources(query, aggregates, resource, source_binding)

strategy(query, resource).add_aggregates(
query,
aggregates,
Expand All @@ -31,6 +33,24 @@ defmodule AshSql.Aggregate do
end
end

defp track_projection_sources(query, aggregates, resource, binding) do
if get_in(query.__ash_bindings__, [:bindings, binding, :projection]) do
Enum.reduce(aggregates, query, fn
%{related?: false}, query ->
query

%{relationship_path: [first | _]}, query ->
relationship = Ash.Resource.Info.relationship(resource, first)
AshSql.Query.Projection.track_source(query, binding, relationship)
Comment on lines +42 to +44

@chatgpt-codex-connector chatgpt-codex-connector Bot Nov 10, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Disable projection pruning for manual aggregate relationships

When an aggregate is attached to a from_many? binding and its first relationship is manual, recording only source_attribute does not capture the callback's dependencies. AshSql.Aggregate.Lateral.apply_relationship_subquery/8 invokes the manual relationship callback directly without marking its accumulator unknown, unlike the manual join and EXISTS paths. For example, a manual count relationship that correlates using another parent column can have that column removed from the source subquery, causing a missing-column SQL error. Mark dependencies unknown for manual aggregate relationships rather than treating their declared source attribute as sufficient.

Useful? React with 👍 / 👎.


_, query ->
query
end)
else
query
end
end

def extract_shared_filters(aggregates) do
AshSql.Aggregate.Lateral.extract_shared_filters(aggregates)
end
Expand Down
7 changes: 6 additions & 1 deletion lib/aggregate/grouped/query.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,11 @@ defmodule AshSql.Aggregate.Grouped.Query do

repo = AshSql.dynamic_repo(resource, implementation, query)

value = repo.one(query, AshSql.repo_opts(repo, implementation, nil, nil, resource))
value =
repo.one(
AshSql.Query.Projection.prune(query),
AshSql.repo_opts(repo, implementation, nil, nil, resource)
)

{:ok, maybe_default_value(value, aggregate)}
end
Expand All @@ -78,6 +82,7 @@ defmodule AshSql.Aggregate.Grouped.Query do

result =
query
|> AshSql.Query.Projection.prune()
|> repo.one(AshSql.repo_opts(repo, implementation, nil, nil, resource))
|> Map.get(aggregate.name)

Expand Down
8 changes: 6 additions & 2 deletions lib/aggregate/lateral/query.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,11 @@ defmodule AshSql.Aggregate.Lateral.Query do

_ ->
repo = AshSql.dynamic_repo(resource, implementation, query)
repo.one(group_query, AshSql.repo_opts(repo, implementation, nil, nil, resource))

repo.one(
AshSql.Query.Projection.prune(group_query),
AshSql.repo_opts(repo, implementation, nil, nil, resource)
)
end

{:ok, add_single_aggs(result, resource, query, cant_group, implementation)}
Expand Down Expand Up @@ -244,7 +248,7 @@ defmodule AshSql.Aggregate.Lateral.Query do
Map.merge(
result || %{},
repo.one(
query,
AshSql.Query.Projection.prune(query),
AshSql.repo_opts(repo, query.__ash_bindings__.sql_behaviour, nil, nil, resource)
)
)
Expand Down
9 changes: 8 additions & 1 deletion lib/bindings.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,14 @@ defmodule AshSql.Bindings do
calculation_names: %{},
context: context,
root_binding: start_bindings,
bindings: %{start_bindings => %{path: [], type: :root, source: resource}}
bindings: %{
start_bindings => %{
path: [],
type: :root,
source: resource,
projection: context[:data_layer][:projection]
}
}
})
end

Expand Down
Loading