Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to jechol/ash_sql#3.
Apply relationship projection pruning immediately before normal reads, lateral relationship loads, aggregate reads and calculation queries execute. Keeping this at the execution boundary lets later calculations, filters and sorts reuse the same relationship join without losing columns.
Add coverage using the existing Post/Comment resources: two calculations on the latest comment, filtering and sorting by another comment field, and loading the complete relationship.
This draft depends on the unreleased ash_sql optimizer. The minimum version is provisionally 0.8.9; confirm the actual release version before upstream submission. Validation used
ASH_VERSION=local ASH_SQL_VERSION=local; the default released dependency cannot satisfy this change yet.Validation: