Skip to content

chore: add Entire's StopFailure hook for Claude Code - #1601

Merged
jdx merged 1 commit into
mainfrom
chore/entire-stop-failure-hook
Oct 31, 2026
Merged

jdx merged 1 commit into
mainfrom
chore/entire-stop-failure-hook

Conversation

@jdx

@jdx jdx commented Oct 31, 2026 •

Copy link
Copy Markdown
Owner

entire status warns "Claude Code hooks out of date · run 'entire enable --force'" in this repository. Entire CLI 0.11.x added a StopFailure hook for Claude Code, which this repository's .claude/settings.json doesn't have yet.

This adds that hook, exactly as entire enable --force --agent claude-code writes it. It's the same sh -c 'if ! command -v entire …; then exit 0; fi; exec entire hooks claude-code stop-failure' form as the existing Entire hooks, so it does nothing where entire isn't installed. entire enable --force also re-sorts .entire/settings.json and .claude/settings.json; those reorderings are left out, so the diff is only the new hook. After the change, entire status on this branch no longer shows the warning.

AI-assisted — Tool: Claude Code; model: anthropic/claude-opus-5-5; version: claude-code_2-1-309_agent.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated the development workflow to run additional handling when a supported tool reports a stop failure. If the tool is unavailable, the workflow exits successfully without running that handling. No changes to the application’s user-facing features or behavior are included in this update.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Central YAML (base), Organization UI (inherited)
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 0fd7d3f8-47e3-4f56-8b5b-94830edb569a
Commits

Reviewing files that changed from the base of the PR and between 47c99d1 and a167bdb.

Files selected for processing: 1
  • .claude/settings.json

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

Walkthrough

The Claude Code settings add a StopFailure hook. The hook runs the Entire stop-failure command when entire is available on PATH; otherwise, it exits successfully.

Changes: StopFailure hook

Layer / File(s) Summary
Configure StopFailure hook
.claude/settings.json
Adds a StopFailure hook that runs entire hooks claude-code stop-failure when entire is on PATH. Otherwise, the command exits successfully.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Merge Risk: Minimal · up to a167b

The configuration-only change adds the intended StopFailure hook without identified merge-blocking risk.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely identifies the addition of Entire's StopFailure hook for Claude Code. It matches the main change in the pull request.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@greptile-apps

greptile-apps Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] This PR appears safe to merge.

Summary

Adds an Entire StopFailure hook to .claude/settings.json.

  • Claude Code sends failed-stop events to Entire.

Reviews (1) · Last reviewed commit: "chore: add Entire's StopFailure hook for..." · Reviewed by Greptile

@jdx
jdx enabled auto-merge (squash) October 31, 2026 16:27
@jdx
jdx merged commit bf16bbb into main Oct 31, 2026
14 checks passed
@jdx
jdx deleted the chore/entire-stop-failure-hook branch October 31, 2026 16:36
@github-actions

Copy link
Copy Markdown
Contributor

Instruction counts

benchmark trend instructions Δ wall (min) Δ
markdown ▂▁▁▁█▇▇▇▇▇▇▇█▇▇▇▇█▇ 266,919,581 → 266,883,752 -0.01% 46.95 → 47.17ms +0.46%
startup ▆▆▆▆█▆▆▆▆▆▆▆▆▆▆▆▆▁▇ 1,010,467 → 1,017,362 +0.68% 1.48 → 1.51ms +2.10%

No instruction-count regression above 1%.

Only instruction counts gate. Wall clock is shown for context — on identical hardware it moves 4-20% run to run.

Measured by tak — instruction-counted CLI benchmarks, stored in this repository's git notes.

Shadow comparison

Parsing mise use -g node@20 against a shadow of mise's committed spec.
Reported, not gated: the shadow grows as the derive learns to express more, so
what to watch is the ratio rather than either column.

framework stripped binary, bytes
usage 1249944
bpaf 2494640
clap 3100904
framework instructions, cold parse vs usage
usage 8295 —
clap 6313736 761x
bpaf 21909300 2641x
                                              min       p01       p10    median
usage-rs: argv -> struct                      733       734       735       742  ns
clap: build tree + parse -> struct        1228755   1236016   1244940   1262779  ns
bpaf: build parser + parse -> struct      3376639   3376639   3405166   3454687  ns

usage: argv -> struct                             750 ns      0.75 µs
clap: build tree + parse -> struct            1261689 ns   1261.69 µs
clap: parse -> struct, tree reused              50702 ns     50.70 µs
clap: build tree only                          749341 ns    749.34 µs

a167bdbd55ab vs 47c99d19007f · measured on the runner, not pushed to the history.

mise-en-dev added a commit that referenced this pull request Nov 1, 2026
### 🐛 Bug Fixes

- **(spec)** reject several targets in a relationship property by
[@jdx](https://github.com/jdx) in
[#1599](#1599)

### 🔍 Other Changes

- add Entire's StopFailure hook for Claude Code by
[@jdx](https://github.com/jdx) in
[#1601](#1601)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant