Repository navigation
chore(rulesets): allow only rebase merges - #255
Conversation
The repo is configured rebase-only, but the ruleset files still allowed merge and squash. Narrow allowed_merge_methods to rebase, matching the org baseline, and carry any live-only pull_request setting into the files so applying them does not silently drop it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Assisted-by: Claude Code:claude-opus-5-5
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: jdwlabs/apps/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review. 📝 WalkthroughWalkthroughThe baseline pull-request rules now require extra approval for unattributed changes and permit only rebase merges. ChangesPull-request rules
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The change matches the stated rebase-only policy, and the live ruleset currently contains the extra-approval setting. The change has not yet been applied, but no concrete merge-blocking failure is established. Architecture SummaryArchitecture risk: 🔵 Low · up to The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency. Changed systems: None identified. Architecture concerns Review detailsBefore / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
PR Code Suggestions ✨Explore these optional code suggestions:
|
jdwillmsen
left a comment
There was a problem hiding this comment.
Reviewed: merge methods narrowed to rebase-only (already enforced by repo settings); live-only settings recorded so apply.sh drops nothing. Checks green, threads resolved.
Why
The repo is configured rebase-only (squash and merge commits disabled), but the ruleset files still allow
merge,squashandrebase. This setsallowed_merge_methodsto["rebase"]inbaseline.json, matching the org baseline change in jdwlabs/.github#55.Needs attention
The live rulesets set
require_extra_approval_for_unattributed_changes: trueand the files did not, so applying would have silently dropped it. Added it to the files, as jdwlabs/.github#55 did.Risk
Low. The repo setting already blocks squash and merge commits, so the live effect is nil. Applying rewrites the listed rulesets in place by id. Not applied yet; run after merge:
Verified
gh api repos/jdwlabs/apps/rulesets/<id>, read-only fields stripped). After this change the only differences are the narrowed merge methods.apply.sh --dry-run: 3 PUTs (Baseline, Branch Naming Convention, Release Tag Protection), no POSTs.jq. There is no ruleset test suite in this repo.Summary by CodeRabbit