fix(serializers): support comma-separated string parsing in TagListSerializerField (#919) - #951
Open
SparshGarg999 wants to merge 3 commits into
Open
Conversation
When TagField has disabled=True, Django passes the initial value into clean().
For ModelForms or initial values providing model instances or tag lists,
super().clean() converted the list to a string ('[<Tag: ...>]') which was
subsequently corrupted by parse_tags().
Safely return non-string values and handle string/None initials when disabled.
Fixes jazzband#943
…n TagListSerializerField (jazzband#919)
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #919
Problem
When using
TaggitSerializerandTagListSerializerField, string inputs were only accepted if they were valid JSON arrays (e.g.["tag1", "tag2"]). Submitting standard comma-separated tag strings (e.g."tag1, tag2"or"\"multi word\", tag3"), like what standard formTagFieldaccepts viaparse_tags(), resulted in aValidationError("invalid_json").Solution
TagListSerializerField.to_internal_valueto support comma-separated and quoted string tag lists viaparse_tags(value)when input is provided in string format.[).tests/test_serializers.pycovering comma-separated strings, quoted strings, empty strings, invalid types, and serializer creation/update workflows.