linkwarden manifest has no Postgres companion: DATABASE_URL points at localhost:5432 that nothing starts, so the app never boots - #2835
linkwarden manifest has no Postgres companion: DATABASE_URL points at localhost:5432 that nothing starts, so the app never boots#2835jaylfc wants to merge 1 commit into
Conversation
…d generated password
- add companions field to linkwarden manifest declaring postgres:16-alpine companion
- update DATABASE_URL to postgresql://linkwarden:{secret_key}@postgres:5432/linkwarden
- modify _generate_compose to handle companions: generate multi-service compose with
linkwarden + postgres services, named volumes, {secret_key}-style password
- test: compose has database service, DATABASE_URL host resolves to postgres service name
Docs-Reviewed: manifest-internal change, no README or catalog listing modification needed
|
ⓘ Qodo reviews are paused because your trial has ended. Ask your workspace admin to add credits to resume reviews. Manage billing |
|
Warning Review limit reachedNext included review available in 9 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
| Returns a ``(compose_dict, host_port)`` tuple. ``host_port`` is | ||
| ``None`` when the manifest declares no ports. | ||
| """ | ||
| # Handle {secret_key} substitution for env vars and companion passwords |
There was a problem hiding this comment.
WARNING: Duplicate secret key logic
The secret key generation and persistence logic here (lines 113-123) duplicates the identical logic in _write_config_files (lines 68-79). If one implementation is updated without the other, the two code paths will diverge, potentially causing inconsistent secrets between config files and compose environment variables.
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
| @pytest.mark.asyncio | ||
| async def test_generate_compose_linkwarden_secret_key_persisted(self, tmp_path): | ||
| """Verify {secret_key} is replaced with a persisted 64-hex-char secret.""" | ||
| installer = DockerInstaller(apps_dir=tmp_path) |
There was a problem hiding this comment.
SUGGESTION: Redundant assignment
installer = DockerInstaller(apps_dir=tmp_path) on line 285 is immediately overwritten by the identical assignment on line 287, making it dead code.
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
Code Review SummaryStatus: 2 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
SUGGESTION
Files Reviewed (4 files)
Fix these issues in Kilo Cloud Reviewed by step-3.7-flash:free · Input: 105.3K · Output: 17.2K · Cached: 179.6K |
1 participant
CARD TITLE (intent, not commit subject): linkwarden manifest has no Postgres companion: DATABASE_URL points at localhost:5432 that nothing starts, so the app never boots
Autonomous build of board card tsk-qnyed7.
linkwarden + postgres services, named volumes, {secret_key}-style password
Docs-Reviewed: manifest-internal change, no README or catalog listing modification needed
Files:
app-catalog/services/linkwarden/manifest.yaml | 11 +-
.../tsk-qnyed7-linkwarden-postgres-companion.md | 3 +
tests/test_installers.py | 170 +++++++++++++++++++++
tinyagentos/installers/docker_installer.py | 57 ++++++-
4 files changed, 238 insertions(+), 3 deletions(-)