Repository navigation
Fix IntelliJ plugin publishing - combine signPlugin and publishPlugin - #128
Merged
Merged
Conversation
- Require approval from 'production' environment before publishing - Applies to both VS Code and IntelliJ release jobs - Prevents unauthorized releases to marketplaces
… invocation IntelliJ Platform Gradle Plugin v2.14.0+ defaults signing properties to CERTIFICATE_CHAIN/PRIVATE_KEY/PRIVATE_KEY_PASSWORD env vars. Running publishPlugin as a separate invocation without these env vars caused the published artifact to be corrupted (marketplace error: 'plugin archive file cannot be extracted'). Combines both tasks into a single invocation so all signing and publishing env vars are available together.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The 0.2.4 IntelliJ plugin release is broken on JetBrains Marketplace with error:
Root Cause
The IntelliJ Platform Gradle Plugin was upgraded from v2.13.1 (0.2.3) to v2.15.0 (0.2.4). Starting in v2.14.0, the plugin defaults signing properties to environment variables CERTIFICATE_CHAIN, PRIVATE_KEY, and PRIVATE_KEY_PASSWORD.
In the release workflow, signPlugin and publishPlugin ran as separate Gradle invocations with different env vars. When publishPlugin ran without the signing env vars, the convention providers resolved to absent values, corrupting the published artifact.
Fix
Combine signPlugin and publishPlugin into a single Gradle invocation with all required env vars present.
After Merge
Re-run the release workflow for IntelliJ to publish a fixed 0.2.4 (or bump to 0.2.5).