Configure RabbitMQ topologies for UOP, Allocations and FAP Results Letters in prod clusters - #427
Conversation
ACLay
left a comment
ACLay
left a comment
There was a problem hiding this comment.
Just reviewing by comparing the branches argocd\uex\dev and argocd\uex\prod directories in kdiff3. There's a few places where the config seems a bit different between them, some of which could cause argocd issues.
The sync wave stuff might be nothing significant, but it does seem a bit inconsistent.
| metadata: | ||
| name: cert-manager | ||
| annotations: | ||
| argocd.argoproj.io/sync-wave: "0" |
There was a problem hiding this comment.
On dev the contents of this metadata block is name: '{{.name}}-cert-manager'. With just name: cert-manager left here, I think it'll cause sync issues as it tries making multiple applications that use the same name.
Also, dev doesn't specify a sync-wave. Does that matter if the prod one is?
There was a problem hiding this comment.
@ACLay Thanks for pointing out the {{.name}} part — I missed that. You're right, without {{.name}}, Argo CD would try to create multiple Applications with the same name.
For the sync wave, it’s needed because the RabbitMQ Cluster Operator CRDs depend on the cert-manager CRDs being available first, so the deployment order matters.
I suspect cert-manager was deployed manually in dev when the RabbitMQ Operator work was initially done, so the CRDs were already there when the Argo CD config was added. That’s probably why a sync wave wasn’t needed there.
| - name: prod-fallback | ||
| template: | ||
| metadata: | ||
| name: rabbitmq-cluster-operator |
There was a problem hiding this comment.
Like with the cert-manager, I think we'll want this name set to '{{.name}}-rabbitmq-cluster-operator'.
This is also specifying a sync-wave that dev isn't.
| - name: prod-fallback | ||
| template: | ||
| metadata: | ||
| name: rabbitmq-topology-operator |
There was a problem hiding this comment.
Same naming issue and sync-wave query here.
2 participants
This PR adds the ArgoCD configuration required to create the RabbitMQ topologies for UOP, Allocations, and FAP Results Letters in the
prod-v4andprod-fallbackclusters.